Skip to content

Include null-safe operator in meta key linting#4139

Merged
mahesh-panchal merged 4 commits intonf-core:devfrom
mahesh-panchal:fix/meta-lint-null-safe
Mar 31, 2026
Merged

Include null-safe operator in meta key linting#4139
mahesh-panchal merged 4 commits intonf-core:devfrom
mahesh-panchal:fix/meta-lint-null-safe

Conversation

@mahesh-panchal
Copy link
Copy Markdown
Member

Description

#4127 Misses the case where the null safe operator might be used on a meta map. This should detect it.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions

This comment was marked as resolved.

@mahesh-panchal mahesh-panchal changed the base branch from main to dev March 27, 2026 10:17
@mahesh-panchal mahesh-panchal changed the title Fix/meta lint null safe Include null-safe operator in meta key linting Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.48%. Comparing base (3f84cbf) to head (cee3d62).
⚠️ Report is 5 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mahesh-panchal mahesh-panchal merged commit 0345e8b into nf-core:dev Mar 31, 2026
111 of 112 checks passed
@mahesh-panchal mahesh-panchal deleted the fix/meta-lint-null-safe branch March 31, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants