Skip to content

modules linting: require registry prefix in container link#4209

Merged
mashehu merged 4 commits intonf-core:devfrom
mashehu:fix-linting-for-container-registry
Apr 22, 2026
Merged

modules linting: require registry prefix in container link#4209
mashehu merged 4 commits intonf-core:devfrom
mashehu:fix-linting-for-container-registry

Conversation

@mashehu
Copy link
Copy Markdown
Contributor

@mashehu mashehu commented Apr 22, 2026

nf-core/modules#11251 broke module linting (which checked for a registry prefix).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.12%. Comparing base (0e87eb7) to head (e79a8d7).
⚠️ Report is 1 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu force-pushed the fix-linting-for-container-registry branch from 4c33ba8 to d0659d9 Compare April 22, 2026 14:59
Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewing after you swapped the pass/fail around

Comment thread nf_core/modules/lint/main_nf.py Outdated
Comment thread nf_core/modules/lint/main_nf.py
@mashehu mashehu force-pushed the fix-linting-for-container-registry branch from d0659d9 to a301ac3 Compare April 22, 2026 15:03
@mashehu mashehu force-pushed the fix-linting-for-container-registry branch from a301ac3 to 9f082b6 Compare April 22, 2026 15:04
@mashehu mashehu force-pushed the fix-linting-for-container-registry branch from 3404543 to e79a8d7 Compare April 22, 2026 16:31
@mashehu mashehu enabled auto-merge (squash) April 22, 2026 16:32
@mashehu mashehu merged commit 14c6cd2 into nf-core:dev Apr 22, 2026
116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants