Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ) | ||
| assert len(mock_lint.failed) == 0 | ||
|
|
||
| # ext.prefixN where N >= 2 should be valid |
There was a problem hiding this comment.
I thought only prefix2 would be allowed, not prefix3
There was a problem hiding this comment.
At the moment I just copied the args code and added prefix as well
There was a problem hiding this comment.
Swapped to just adding prefix2 directly to the allowed keys.
| mock_lint, | ||
| [ | ||
| """ | ||
| def prefix2 = task.ext.prefix2 ?: '' |
There was a problem hiding this comment.
Can you add a test for prefix1 and other not permitted combos too please.
There was a problem hiding this comment.
Added a test for prefix1.
mahesh-panchal
left a comment
There was a problem hiding this comment.
The invalid keys are not in the test itself
mahesh-panchal
left a comment
There was a problem hiding this comment.
Thank you. Don't forget the website docs too.
In the April maintainers meeting we agreed to allow task.ext.prefix2 as an option for modules that really need it, as an analogy to
ext.args,ext.args2etc.This PR actually allows any number of numbered prefix values, in the same way as we do for
args(using the same code).PR checklist
CHANGELOG.mdis updateddocsis updated