1929: local modules use remote format from template#3256
1929: local modules use remote format from template#3256awgymer merged 14 commits intonf-core:devfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
|
||
| """ | ||
| if module.nftest_testdir is None or module.nftest_main_nf is None: | ||
| raise ValueError() |
There was a problem hiding this comment.
don't we want to allow local modules to not have these files?
There was a problem hiding this comment.
Yes, this was my first-pass to get mypy happy so I could run the tests on GitHub yesterday. I am updating the individual lint tests to be a bit more permissive of missing files for local modules.
|
There are currently no tests at all implemented for the linting of local modules or subworkflows 😱 |
mirpedrol
left a comment
There was a problem hiding this comment.
The code looks good, but there is a test failing, LGTM once this is fixed 🚀
Co-authored-by: Júlia Mir Pedrol <[email protected]>
e7d58cb to
5689ff6
Compare
mirpedrol
left a comment
There was a problem hiding this comment.
Great! thanks for implementing this
PR checklist
CHANGELOG.mdis updateddocsis updated