Add linting for ifEmpty(null)#3411
Merged
lmReef merged 12 commits intonf-core:devfrom Jan 27, 2025
Merged
Conversation
Contributor
|
@nf-core-bot fix linting |
mirpedrol
reviewed
Jan 21, 2025
Member
mirpedrol
left a comment
There was a problem hiding this comment.
Hi @lmReef, thanks for contributing!
It is looking good, but we should also add a test for this. You can find samples for other linting tests in tests/pipelines/lint, I think https://github.com/nf-core/tools/blob/main/tests/pipelines/lint/test_template_strings.py will be useful for this case
Contributor
Author
|
awesome thanks for the feedback, I'll make those changes |
Contributor
Author
|
@nf-core-bot fix linting |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
mirpedrol
approved these changes
Jan 24, 2025
Co-authored-by: Júlia Mir Pedrol <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pipeline and subworkflow linting for ifEmpty(null)
Resolves issue #2506
Description from original issue
Warning message example:

Implementation based on
pipeline_todosas it's very similar (link to main file)Uses regex pattern
ifEmpty\(\s*null\s*\)PR checklist
CHANGELOG.mdis updateddocsis updated