output passed to write_params_file as Path object#3435
Merged
mashehu merged 3 commits intonf-core:devfrom Jan 30, 2025
Merged
Conversation
mashehu
approved these changes
Jan 30, 2025
Contributor
mashehu
left a comment
There was a problem hiding this comment.
Awesome, thanks for finding and fixing this bug!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix of #3434 : Incorrect Argument Type in
write_params_file()When running the command
nf-core pipelines create-params-file, anAttributeErrorwas raised because thewrite_params_file()method ofParamsFileBuilderexpected its first argument to be aPathobject. However, a string representing the output parameter file name was passed instead, causing the error.This fix ensures that the argument is properly converted to a
Pathobject before being passed towrite_params_file(), resolving the issue.PR checklist
CHANGELOG.mdis updateddocsis updated