Update dead link#3505
Closed
Aratz wants to merge 1 commit intonf-core:devfrom
Closed
Conversation
Contributor
Author
|
Wait, I'm not sure how this happened, but it looks like my commit ended up on dev already 🙈 (815f972) I shouldn't be allowed to push directly to the origin repo, right? Can you please check and tell me what I did wrong? |
Contributor
|
Hey @Aratz, it seems that you were able to force push into dev. I think that can be disabled in settings |
Contributor
|
the problem was probably that you pushed from a branch called dev, then our changelog automation sometimes seems to be pushing to the same branch on tools, that's why it might have ended up there. Haven't had time to thoroughly test that theory, but you are not the first one to happen this to. |
Contributor
Author
|
I see, in the future, I'll make sure to use feature branches, thanks for the explanation, I'll close this PR then 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going through the list of todos for nf-core/seqinspector I found a dead link. The link is now fixed.
PR checklist
CHANGELOG.mdis updated