Skip to content

merge to main for patch 3.2.1#3546

Merged
mirpedrol merged 13 commits intonf-core:mainfrom
mirpedrol:patch-3.2.1
Apr 30, 2025
Merged

merge to main for patch 3.2.1#3546
mirpedrol merged 13 commits intonf-core:mainfrom
mirpedrol:patch-3.2.1

Conversation

@mirpedrol
Copy link
Copy Markdown
Member

@mirpedrol mirpedrol commented Apr 25, 2025

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 25, 2025

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @mirpedrol,

It looks like this pull-request is has been made against the mirpedrol/tools main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the mirpedrol/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

JulianFlesch
JulianFlesch reviewed Apr 30, 2025
View reviewed changes
Comment thread tests/utils.py
JulianFlesch
JulianFlesch reviewed Apr 30, 2025
View reviewed changes
Comment thread setup.py
JulianFlesch
JulianFlesch reviewed Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JulianFlesch JulianFlesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the PRs referenced in the path changelog to confirm only what is mentioned there is changed. Each of those entries has already been reviewed.

The changes to setup.py and tests/utils.py are not mentioned in the changelog. I assume those were added by mistake or should be added to the changelog.

JulianFlesch
JulianFlesch approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JulianFlesch JulianFlesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@mirpedrol mirpedrol merged commit e6497bc into nf-core:main Apr 30, 2025
89 of 92 checks passed
@mirpedrol mirpedrol deleted the patch-3.2.1 branch April 30, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulianFlesch JulianFlesch JulianFlesch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mirpedrol @JulianFlesch @mashehu @nf-core-bot