Enable CI tests for pipelines/download#3898
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
602241d to
8be4478
Compare
8be4478 to
bae5110
Compare
MatthiasZepper
left a comment
There was a problem hiding this comment.
Thanks a lot for this very observant bug fix!
No objections, just thinking we should also directly bump the Singularity version in the process. That may also explain the different error messages...
There was a problem hiding this comment.
Excellent catch! It totally escaped me, that we are running Singularity tests in that action as well.
In the pipeline template, we have upgraded the download test nf_core/pipeline-template/.github/workflows/download_pipeline.yml to Apptainer 1.34 instead of Singularity 3.8.3, which is about 3 years more recent. I think, this would be a good opportunity to piggy-back this change to the #tools test as well.
@mirpedrol @mashehu, @JulianFlesch any opinions against which Apptainer version we should test the pipelines and thus also tools?
Co-authored-by: Matthias Zepper <[email protected]>
This PR reactivates some of the download tests that stopped running after restructuring the tests. It also includes fixes for undetected errors. Note the last commit adds a new error message type. I haven't validated if this is due to singularity changing the error message in the past or if something else went wrong. So you maybe take a deeper look at this.
PR checklist
CHANGELOG.mdis updateddocsis updated