Merged
Conversation
Contributor
|
@nf-core-bot changelog |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
780780e to
5bb2354
Compare
b09d324 to
02e07e3
Compare
Contributor
Author
|
@mashehu can this be merged? The errors seem not related. They are already present in dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on our infrastructure I get different error messages for the invalid docker pulls.
For example in the test
test_docker_save_imagethe error for the imagethis-image-cannot-possibly-be-pulled-to-this-machine:latestisError response from daemon: No such image: this-image-cannot-possibly-be-pulled-to-this-machine:latest\nand thus does not match any of the patterns in theDockerErrorclass.Or in
test_docker_pull_image_docker_installedfor the containerghcr.io/not-a-real-registry/this-container-does-not-existthe actual error message isUsing default tag: latest\n', 'Error response from daemon: error from registry: denied\n', 'denied\n'.Thus, it will return
OtherErrorwhich causes the test cases to fail. I am not really sure, what is expected here, so I added OtherError as possible assert.Blocked by #3920
PR checklist
CHANGELOG.mdis updateddocsis updated