Skip to content

WIP: Fix getStream from forwarding inports #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bergie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: Fix getStream from forwarding inports #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions spec/Component.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2105,6 +2105,58 @@ describe 'Component', ->
sin1.post new noflo.IP 'data', 'moose'
sin1.post new noflo.IP 'closeBracket', 'foo'
sin1.post new noflo.IP 'closeBracket'
it 'should trigger only when a full stream has been received even when forwarding', (done) ->
c = new noflo.Component
inPorts:
in:
datatype: 'string'
outPorts:
out:
datatype: 'int'
stream:
datatype: 'boolean'
forwardBrackets:
in: ['out']
process: (input, output) ->
hasStream = input.hasStream 'in'
return if input.ip.type isnt 'data' and not hasStream
output.send
stream: hasStream
return output.done() unless hasStream
data = input.getStream 'in'
output.sendDone
out: data.length

expected = [
['stream', 'data', false] # First data
['stream', 'data', false] # Second data
['stream', 'data', false] # Third data
['stream', 'data', true] # last closeBracket giving us a stream
['out', 'openBracket', 'foo']
['out', 'data', 3]
['out', 'closeBracket', 'foo']
]
received = []
sout1.on 'ip', (ip) ->
received.push ['stream', ip.type, ip.data]
return unless received.length is expected.length
chai.expect(received).to.eql expected
done()
sout2.on 'ip', (ip) ->
received.push ['out', ip.type, ip.data]
return unless received.length is expected.length
chai.expect(received).to.eql expected
done()
c.inPorts.in.attach sin1
c.outPorts.stream.attach sout1
c.outPorts.out.attach sout2
sin1.post new noflo.IP 'openBracket', 'foo'
sin1.post new noflo.IP 'data', 'moose'
sin1.post new noflo.IP 'openBracket', 'bar'
sin1.post new noflo.IP 'data', 'is'
sin1.post new noflo.IP 'closeBracket', 'bar'
sin1.post new noflo.IP 'data', 'big'
sin1.post new noflo.IP 'closeBracket', 'foo'

describe 'with a simple ordered stream', ->
it 'should send packets with brackets in expected order when synchronous', (done) ->
Expand Down