Fix keyboard and mouse input on Windows ARM64#618
Open
andreban wants to merge 1 commit intonot-fl3:masterfrom
Open
Fix keyboard and mouse input on Windows ARM64#618andreban wants to merge 1 commit intonot-fl3:masterfrom
andreban wants to merge 1 commit intonot-fl3:masterfrom
Conversation
On aarch64, neither the x86_64 nor x86 cfg guards matched, so SetWindowLongPtrA was never called to store the WindowsDisplay pointer in the window's user data slot. win32_wndproc always read 0, hit the early-return guard, and silently dropped every keyboard and mouse event. Fix both affected sites (run() and set_fullscreen()) by extending the x86_64 cfg to also cover aarch64, which is likewise a 64-bit platform and uses SetWindowLongPtrA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On aarch64, neither the x86_64 nor x86 cfg guards matched, so SetWindowLongPtrA was never called to store the WindowsDisplay pointer in the window's user data slot. win32_wndproc always read 0, hit the early-return guard, and silently dropped every keyboard and mouse event.
Fix both affected sites (run() and set_fullscreen()) by extending the x86_64 cfg to also cover aarch64, which is likewise a 64-bit platform and uses SetWindowLongPtrA.
Closes #614