Add ArtifactDir() to support Go 1.26 testing.TB interface#1648
Merged
onsi merged 1 commit intoonsi:masterfrom Apr 6, 2026
Merged
Add ArtifactDir() to support Go 1.26 testing.TB interface#1648onsi merged 1 commit intoonsi:masterfrom
onsi merged 1 commit intoonsi:masterfrom
Conversation
Go 1.26 added ArtifactDir() string to the testing.TB interface. This adds the method to GinkgoTInterface, GinkgoTBWrapper, and ginkgoTestingTProxy to maintain compatibility. Fixes onsi#1640
Mic92
added a commit
to Mic92/nixpkgs
that referenced
this pull request
Mar 25, 2026
Go 1.26 added ArtifactDir() to the testing.TB interface. Ginkgo 2.28.1 doesn't implement this method yet, causing test failures. Add a patch to implement the missing method. onsi/ginkgo#1648
Mic92
added a commit
to Mic92/nixpkgs
that referenced
this pull request
Mar 25, 2026
Go 1.26 added ArtifactDir() to the testing.TB interface. Ginkgo 2.28.1 doesn't implement this method yet, causing test failures. Add a patch to implement the missing method. onsi/ginkgo#1648
13 tasks
github-actions Bot
pushed a commit
to Mic92/nixpkgs
that referenced
this pull request
Mar 29, 2026
Go 1.26 added ArtifactDir() to the testing.TB interface. Ginkgo 2.28.1 doesn't implement this method yet, causing test failures. Add a patch to implement the missing method. onsi/ginkgo#1648
Mic92
added a commit
to Mic92/nixpkgs
that referenced
this pull request
Apr 1, 2026
Go 1.26 added ArtifactDir() to the testing.TB interface. Ginkgo 2.28.1 doesn't implement this method yet, causing test failures. Add a patch to implement the missing method. onsi/ginkgo#1648
1 task
Mic92
added a commit
to Mic92/nixpkgs
that referenced
this pull request
Apr 3, 2026
Go 1.26 added ArtifactDir() to the testing.TB interface. Ginkgo 2.28.1 doesn't implement this method yet, causing test failures. Add a patch to implement the missing method. onsi/ginkgo#1648
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.26 added
ArtifactDir() stringto thetesting.TBinterface. This adds the method toGinkgoTInterface,GinkgoTBWrapper, andginkgoTestingTProxyto maintain compatibility.The implementation creates a temporary directory (similar to
TempDir()) but without automatic cleanup, matching the semantics oftesting.T.ArtifactDir()which provides a persistent directory for test artifacts.Fixes #1640