Skip to content

Add AddArguments to TableEntry#974

Open
kaovilai wants to merge 1 commit intoonsi:masterfrom
kaovilai:TableEntry_AddArguments
Open

Add AddArguments to TableEntry#974
kaovilai wants to merge 1 commit intoonsi:masterfrom
kaovilai:TableEntry_AddArguments

Conversation

@kaovilai
Copy link
Copy Markdown

@kaovilai kaovilai commented May 4, 2022

For usecase like below to reduce repeating arguments in each entry increasing test description complexity unnecessarily.

var declaration is unnecessary but here for object type visibility.

for i, _ := range awsTests {
		var entry *TableEntry
		entry = &awsTests[i]
		entry.AddArguments(Label("aws"))
	}
	genericTests = append(genericTests, awsTests...)
}

For usecase like below to reduce repeating arguments
```
for i, _ := range awsTests {
		var entry *TableEntry
		entry = &awsTests[i]
		entry.AddArguments(Label("aws"))
	}
	genericTests = append(genericTests, awsTests...)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant