Fix blank lines being ignored#813
Merged
aminya merged 3 commits intoatom-minimap:masterfrom Oct 28, 2024
sparklost:fix_blank_line
Merged
Fix blank lines being ignored#813aminya merged 3 commits intoatom-minimap:masterfrom sparklost:fix_blank_line
aminya merged 3 commits intoatom-minimap:masterfrom
sparklost:fix_blank_line
Conversation
Collaborator
|
Thanks. Please include the dist changes |
Contributor
Author
|
Note about creating dist: I also modified |
aminya
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimap drawing ignores blank lines and "glues" code lines together.
But this is not the case where there is indentation before those blank lines.
This makes some problems:
Before changes:
Several blank lines are in the code before these lines.
Highlighted lines from minimap-bookmarks and minimap-selection plugins are mismatched on the minimap, with what is seen in the editor.
After changes:
Several blank lines are in the code before these lines.
Everything is perfectly matched.
And it might be even a little faster.
Should I rebuild
dist/with parcel for this PR, or it is done at new version release time?Also, could some member please release new version so changes from this and previous PR are available to everyone.