More config options#2
Open
sdemura wants to merge 3 commits intoatosatto:masterfrom
Open
Conversation
added 3 commits
February 1, 2018 12:18
Adds some more config options to make this role more useable - config dir support - region support - create data directories with proper permissions
Adds more server options to make this role a bit more useable - config dir support - region support - create data dirs with permissions
SuperQ
requested changes
Jun 25, 2018
Collaborator
SuperQ
left a comment
There was a problem hiding this comment.
I like the idea.
Please rebase and update the README.
| minio_server_opts: "" | ||
|
|
||
| # Directory to store minio config. Will default to minio_user/.minio if not defined | ||
| minio_config_dir: "" |
Collaborator
There was a problem hiding this comment.
Let's set a default to /etc/minio.
| owner: "{{ minio_user }}" | ||
| group: "{{ minio_group }}" | ||
| state: directory | ||
| when: minio_config_dir is defined |
Collaborator
There was a problem hiding this comment.
This when won't work because it's defined as "" in the defaults. Let's just set a sane default.
| mode: 0755 | ||
| when: ansible_service_mgr != "systemd" | ||
|
|
||
| - name: create the minio data directory |
paulfantom
requested changes
Jun 25, 2018
| owner: "{{ minio_user }}" | ||
| group: "{{ minio_group }}" | ||
| state: directory | ||
| when: minio_config_dir is defined |
Collaborator
There was a problem hiding this comment.
minio_config_dir is always defined (defined in defaults/main.yml). better would be to check if variable is an empty string or not.
| minio_server_opts: "" | ||
|
|
||
| # Directory to store minio config. Will default to minio_user/.minio if not defined | ||
| minio_config_dir: "" |
Collaborator
There was a problem hiding this comment.
This should be also added to README.md with a short explanaition.
akire0ne
pushed a commit
to akire0ne/ansible-minio
that referenced
this pull request
Feb 15, 2022
Pass the `$MINIO_ARGS` var to ExecStart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more server options to make this role a bit more useable