Skip to content

Migrated notifications from webhook to power automate #372

Merged
abahmed merged 6 commits intoabahmed:mainfrom
jothilal22:teams-power-automate-migration
Feb 18, 2025
Merged

Migrated notifications from webhook to power automate #372
abahmed merged 6 commits intoabahmed:mainfrom
jothilal22:teams-power-automate-migration

Conversation

@jothilal22
Copy link
Copy Markdown
Contributor

Fixes # .

**Changes proposed in this pull request: * *

  • Removed Webhook-based notification system.

Testing

  • Verified notifications are working correctly with Power Automate.

Please review and let me know if any improvements are needed

teamstest

@jothilal22 jothilal22 requested a review from abahmed as a code owner February 16, 2025 16:48
@abahmed
Copy link
Copy Markdown
Owner

abahmed commented Feb 16, 2025

Hello @jothilal22
Thank you for raising this!
The PR looks good for me, there's only an error coming from testing step can you check it?

alertmanager/teams/teams_test.go:123:31: cannot use appCfg (variable of type *struct{}) as *config.App value in argument to NewTeams

@jothilal22
Copy link
Copy Markdown
Contributor Author

@abahmed Thanks for reviewing. Can you please check now appCfg issue is resolved.

@abahmed
Copy link
Copy Markdown
Owner

abahmed commented Feb 16, 2025

@abahmed Thanks for reviewing. Can you please check now appCfg issue is resolved.

@jothilal22 Thank you for resolving it, but there's another issue (https://github.com/abahmed/kwatch/actions/runs/13357776430/job/37302905119?pr=372)

time="2025-02-16T18:41:03Z" level=info msg="initializing Google Chat with webhook url: test" --- FAIL: TestGetProviders (0.00s) alertmanager_test.go:103: Error Trace: /home/runner/work/kwatch/kwatch/alertmanager/alertmanager_test.go:103 Error: "[0xc00051c1b0 0xc000[26](https://github.com/abahmed/kwatch/actions/runs/13357776430/job/37302905119?pr=372#step:5:27)2000 0xc00051c300 0xc00025a3c0 0xc000262050 0xc0002620a0 0xc00051c5d0 0xc0002620f0 0xc00025a7c0 0xc000262140 0xc00025a880 0xc0001d4060 0xc00051c870 0xc00051c960]" should have 15 item(s), but has 14 Test: TestGetProviders Messages: get providers returned %d expected %d time="2025-02-16T18:41:03Z" level=info msg="sending event: {PodName: ContainerName: Namespace: Reason: Events: Logs: Labels:map[]}" time="2025-02-16T18:41:03Z" level=error msg="failed to send event with Slack Error: error" time="2025-02-16T18:41:03Z" level=info msg="sending message: hello world!" time="2025-02-16T18:41:03Z" level=error msg="failed to send msg with Slack Error: error" FAIL

Copy link
Copy Markdown
Owner

@abahmed abahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it's not related, will be fixed in another PR
Thank you @jothilal22!

@abahmed abahmed merged commit 3c94828 into abahmed:main Feb 18, 2025
@jothilal22
Copy link
Copy Markdown
Contributor Author

Sure @abahmed I also looked we need to change one thing in this file https://github.com/abahmed/kwatch/blob/main/alertmanager/alertmanager_test.go#L59

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants