[feature] Allow configuring caching#49
Open
hallelujah wants to merge 4 commits intoabeidahmed:mainfrom
Open
Conversation
As with Rails, this allows to configure the cache store through `config.rails_heroicon_cache_store` By default it is set to :memory_store. Closes abeidahmed#48
a89c33b to
3a140a3
Compare
So that all tests benefits from Railtie initialization
Owner
|
Thanks for the contribution, @hallelujah. I can see the benefits of using a cache store, but I'll need to benchmark the SVG render speed when compared to the existing hash store. FYI: This is the issue #34 that hash store was trying to fix. |
Author
|
Thanks for the answer. Let's see if we do not lose too much in performance using MemoryStore Also for my case, I would like to be able to share the cache between multiple processes in production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with Rails, this allows to configure the cache store through
config.rails_heroicon_cache_storeBy default it is set to :memory_store.
Closes #48