Update dependencies to support PHP 7.4#56
Merged
itafroma merged 18 commits intoacquia:masterfrom Sep 30, 2020
Merged
Conversation
Contributor
Author
|
Addressed some issues after running on Travis:
|
Contributor
Author
|
Symfony's PSR7 Message Bridge dropped support for its Diactoros-specific message factory in 1.3, making it impossible to support the following configuration: Diactoros < 2.0 Symfony recommends using Nyholm's PSR7 library instead: we were only using Diactoros for its message factories, so replaced it with Nyholm. This also vastly reduces the number of dependency configurations we need to test. |
Contributor
Author
|
All build errors fixed and we finally have a green board: this is ready for review. |
roseofgold
suggested changes
Sep 28, 2020
roseofgold
left a comment
There was a problem hiding this comment.
Looks good. Just one code style question.
roseofgold
approved these changes
Sep 28, 2020
ndelrossi
approved these changes
Sep 28, 2020
miniyarov
reviewed
Sep 29, 2020
miniyarov
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides support for PHP 7.4 by updating development dependencies and expanding support for Symfony 5.
To support PHP 7.4, we've had to make the following backwards-incompatible changes:
Because of this, the next release after merging this PR will be 5.0.0 and will only support PHP 7.2 and later.
To ensure continued compatibility, I've also adjusted the Travis configuration file to test all permutations of the dependencies we support.