Open
Conversation
This makes it much easier to share magic links, as we don't have to manually enter the correct task etc, if we have an activity or task that matches our request already.
Member
Author
|
Implements #79 (mostly) |
derrabauke
reviewed
Feb 19, 2026
| </div> | ||
| <div | ||
| class="form-list-cell form-group cell-buttons grid grid-cols-2 justify-around gap-2 self-center text-sm [&>*]:px-2" | ||
| class="form-list-cell form-group cell-buttons grid grid-cols-3 justify-around gap-2 self-center text-sm [&>*]:px-2" |
Member
There was a problem hiding this comment.
I think that needs a change in the grid layout of the wrapping ValidatedForm > lg:grid-cols-[...repeat(3,[...])]
derrabauke
reviewed
Feb 19, 2026
Member
There was a problem hiding this comment.
Instead of adding the button to every row, couldn't we move it into the edit view of the report? Would lead to less overload of the UI.
This allows us a flexible workflow of "resuming" activities or reports by clicking the magic link, then clicking "create report", which will then behave just as if we clicked someone else's magic link
39ed822 to
ff07682
Compare
This breaks builds and dev env - let's add it again later
2f1488f to
3aad90b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it much easier to share magic links, as we don't have to
manually enter the correct task etc, if we have an activity or task
that matches our request already.
We now also can create reports from the magic-link dialog, which
allows us a flexible workflow of "resuming" activities
or reports by clicking the magic link, then clicking "create report", which
will then behave just as if we clicked someone else's magic link