feat: toggle analysis table column by MitanOmar · Pull Request #1115 · adfinis/timed

MitanOmar · 2026-03-16T12:11:52Z

derrabauke

Generally don't scope only to analysis. That's a feature we will apply to other tables with a high probability. So all the analysis-** prefixed naming --> re-usable component.

derrabauke · 2026-03-16T15:31:31Z

Could we make this more re-usable? Think of it as a service for multiple tables/components. There will be future scenarios where users need to store some UI relevant settings. And that will be the service for it. We don't want to create a new service for each UI setting topic.

I'd suggest the naming UserSettingsService. And probably it's best to store the table column configurations in a configuration file like app/config/table-columns.js so it's easy to extract this service+config in the future to the ui-core addon and we can add column configurations for other tables easily.

As discussed:

UserSettingsService handles the storing/loading

We gonna provide default settings ala:

app/config/table-columns.js (this can include multiple table configurations)

app/config/appearance.js

The default setting should also define the storage (sub-) key, format: `${user-settings-key}-${sub-setting-key}

derrabauke · 2026-03-16T15:39:53Z

And of course tests are missing. :-)

MitanOmar · 2026-03-16T15:51:56Z

And of course tests are missing. :-)

i did not write tests yet, just to get confirmation about if this is the right way to implement it

c0rydoras · 2026-03-18T08:04:39Z

@@ -0,0 +1,5 @@
+<colgroup>
+  {{#each @columns as |column|}}
+    <col class={{concat "w-[" column.width "%]"}} />


that only works if the classes w-[x%] are defined/used elsewhere (with their full name), otherwise tailwind won't include them in the CSS bundle

This is the same issue you @MitanOmar faced with #1139 (comment)

@derrabauke will take care of that as well

c0rydoras · 2026-03-18T08:06:54Z

+export default class AnalysisTableColumnsService extends Service {
+  localStorageKey = "hidden-analysis-table-column";
+  @tracked hiddenColumns = [];
+  @tracked allTableColumns = [


this is constant, why is it tracked?

nitpick: move it, and the localStorageKey outside of the class (and rename them so its clear they're constants, e.g. ALL_TABLE_COLUMNS and LOCAL_STORAGE_KEY)

derrabauke · 2026-04-01T12:59:29Z

We could also make this more agnostic. ~~analysis-columns-modal~~ -> column-selector-modal

…vices

derrabauke · 2026-04-14T13:17:28Z

+  @action
+  save() {
+    this.userSettings.updateHiddenColumns("analysisTable", this.localhidden);
+    this.notify.success("The columns are updated successfully");


Not necessary, only notify the user if it fails.

derrabauke · 2026-04-14T13:24:48Z

+  constructor(userSettings) {
+    this.userSettings = userSettings;
    this.loadConfiguration();
  }


What is that? Why not inject the service as normal? Or extend it?

derrabauke · 2026-04-14T13:25:29Z

+  load(subServiceKey, defaultValue) {
+    const fullKey = `${USER_SETTINGS_KEY}.${subServiceKey}`;
+    const localStorageValue = localStorage.getItem(fullKey);
+    if (!localStorageValue && typeof defaultValue !== "undefined") {
+      localStorage.setItem(fullKey, JSON.stringify(defaultValue));
+      return defaultValue;
+    }
+    return localStorageValue ? JSON.parse(localStorageValue) : defaultValue;
+  }


Drop the whole sub-service thingy. Make it flat & simple.

derrabauke · 2026-04-20T11:29:16Z

+      return {
+        ...col,
+        isVisible:
+          userPreference !== undefined ? userPreference : col.isVisible,


Suggested change

userPreference !== undefined ? userPreference : col.isVisible,

userPreference !== undefined ? userPreference.isVisible : col.isVisible,

derrabauke · 2026-04-20T11:31:13Z

+      ...this._overrides,
+      [tableId]: {
+        ...(this._overrides[tableId] || {}),
+        [columnId]: isVisible,


Suggested change

[columnId]: isVisible,

[columnId]: { isVisible },

derrabauke · 2026-04-20T11:33:36Z

+export default class AnalysisColumnsModal extends Component {
+  @service userSettings;
+  @service notify;
+
+  /** just to not call the update with each toggle,
+   * we are saving a local copy,
+   * and updating with save function
+   */
+  @tracked localhidden = [];
+
+  get hiddenColumns() {
+    return this.localhidden;
+  }
+
+  constructor(...args) {
+    super(...args);
+    this.localhidden = this.userSettings
+      .getTableColumns("analysis")
+      .filter((col) => !col.isVisible)
+      .map((col) => col.lable);
+  }
+
+  get allTableColumns() {
+    return this.userSettings.getTableColumns("analysis");
+  }
+
+  @action
+  toggleColumn(columnLabel) {
+    if (this.localhidden.includes(columnLabel)) {
+      this.localhidden = this.localhidden.filter(
+        (label) => label !== columnLabel,
+      );
+      return;
+    }
+    this.localhidden.push(columnLabel);
+  }
+
+  @action
+  save() {
+    try {
+      for (const column of this.allTableColumns) {
+        this.userSettings.updateColumnVisibility(
+          "analysis",
+          column.label,
+          this.localhidden.includes(column.label),
+        );
+      }
+      this.args.onClose();
+    } catch (error) {
+      console.log({ error });
+      this.notify.error("An error when updating the columns visibility");
+    }
+  }
+}


Suggested change

export default class AnalysisColumnsModal extends Component {

@service userSettings;

@service notify;

/** just to not call the update with each toggle,

* we are saving a local copy,

* and updating with save function

*/

@tracked localhidden = [];

get hiddenColumns() {

return this.localhidden;

}

constructor(...args) {

super(...args);

this.localhidden = this.userSettings

.getTableColumns("analysis")

.filter((col) => !col.isVisible)

.map((col) => col.lable);

}

get allTableColumns() {

return this.userSettings.getTableColumns("analysis");

}

@action

toggleColumn(columnLabel) {

if (this.localhidden.includes(columnLabel)) {

this.localhidden = this.localhidden.filter(

(label) => label !== columnLabel,

);

return;

}

this.localhidden.push(columnLabel);

}

@action

save() {

try {

for (const column of this.allTableColumns) {

this.userSettings.updateColumnVisibility(

"analysis",

column.label,

this.localhidden.includes(column.label),

);

}

this.args.onClose();

} catch (error) {

console.log({ error });

this.notify.error("An error when updating the columns visibility");

}

}

}

import { tracked } from "tracked-built-ins";

export default class AnalysisColumnsModal extends Component {

@service userSettings;

@service notify;

columns = tracked(this.userSettings.getTableColumns("analysis")); // that's all you need

@action

toggleColumn(column) {

column.isVisible = !column.isVisible

this.columns = [...this.columns]

}

@action

save() {

try {

for (const column of this.columns) {

this.userSettings.updateColumnVisibility(

"analysis",

column.label,

column.isVisible,

);

}

this.args.onClose();

} catch (error) {

console.log({ error });

this.notify.error("An error when updating the columns visibility");

}

}

}

MitanOmar self-assigned this Mar 16, 2026

MitanOmar requested a review from derrabauke March 16, 2026 12:16

MitanOmar force-pushed the toggle-analysis-table-columns branch from b44fe84 to 43c9aa4 Compare March 16, 2026 14:28

MitanOmar changed the title ~~feat: WIP toggle analysis table column~~ feat: toggle analysis table column Mar 16, 2026

MitanOmar marked this pull request as ready for review March 16, 2026 14:42

MitanOmar requested a review from a team as a code owner March 16, 2026 14:42

MitanOmar mentioned this pull request Mar 16, 2026

[ENHANCEMENT]: Configurable columns in analysis tab #1083

Open

1 task

derrabauke requested changes Mar 16, 2026

View reviewed changes

c0rydoras requested changes Mar 18, 2026

View reviewed changes

derrabauke reviewed Apr 1, 2026

View reviewed changes

MitanOmar force-pushed the toggle-analysis-table-columns branch from 43c9aa4 to 7568aa5 Compare April 10, 2026 00:49

MitanOmar marked this pull request as draft April 10, 2026 00:56

MitanOmar added 5 commits April 13, 2026 09:41

feat: toggle analysis table column

19a8c60

refactor: user settings with the new pattern

7f0d24f

refactor: move storage key from helper to main class

cdc79b3

refactor: convert appearance service to user settings sub service

a295c90

refactor: allow user settings sub services to access native ember ser…

27766d1

…vices

MitanOmar force-pushed the toggle-analysis-table-columns branch from cbc4c1b to 27766d1 Compare April 13, 2026 07:43

WIP: prepare putting all settings in UserSettings service

505da29

derrabauke requested changes Apr 14, 2026

View reviewed changes

derrabauke reviewed Apr 14, 2026

View reviewed changes

Comment thread frontend/app/analysis/index/controller.js Outdated

WIP: another example of strcturing user settings service

5ad4632

derrabauke requested changes Apr 20, 2026

View reviewed changes

WIP

1c7158f

	userPreference !== undefined ? userPreference : col.isVisible,
	userPreference !== undefined ? userPreference.isVisible : col.isVisible,

Conversation

MitanOmar commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derrabauke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

derrabauke Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

derrabauke commented Mar 16, 2026

Uh oh!

MitanOmar commented Mar 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MitanOmar commented Mar 16, 2026 •

edited

Loading

derrabauke Apr 1, 2026 •

edited

Loading