Skip to content

fix: do not allow verifying & moving reports at the same time#1124

Merged
c0rydoras merged 5 commits intoadfinis:mainfrom
c0rydoras:fix/backend/issue-1047-1
Mar 23, 2026
Merged

fix: do not allow verifying & moving reports at the same time#1124
c0rydoras merged 5 commits intoadfinis:mainfrom
c0rydoras:fix/backend/issue-1047-1

Conversation

@c0rydoras
Copy link
Copy Markdown
Collaborator

@c0rydoras c0rydoras commented Mar 20, 2026

No description provided.

@c0rydoras c0rydoras changed the title fix(backend): do not allow verifying & moving reports at the same time fix: do not allow verifying & moving reports at the same time Mar 20, 2026
@c0rydoras c0rydoras marked this pull request as ready for review March 20, 2026 14:22
@c0rydoras c0rydoras requested review from a team as code owners March 20, 2026 14:22
@c0rydoras c0rydoras linked an issue Mar 20, 2026 that may be closed by this pull request
[ENHANCEMENT]: Comment Box & History Record when moving a Timed Entry to a different task, project or customer #1047
Open
1 task
open-dynaMIX
open-dynaMIX requested changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@open-dynaMIX open-dynaMIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

Just some ruff edges 😉

Comment thread backend/timed/tracking/tests/test_report.py Outdated
Comment thread backend/timed/tracking/tests/test_report.py Outdated
Comment thread backend/timed/tracking/tests/test_report.py Outdated
@c0rydoras c0rydoras force-pushed the fix/backend/issue-1047-1 branch from 832cf9f to b02965c Compare March 23, 2026 09:00
@c0rydoras c0rydoras requested a review from open-dynaMIX March 23, 2026 09:00
@c0rydoras c0rydoras force-pushed the fix/backend/issue-1047-1 branch from b02965c to ebb9c76 Compare March 23, 2026 09:39
@c0rydoras c0rydoras requested a review from derrabauke March 23, 2026 09:39
@c0rydoras c0rydoras force-pushed the fix/backend/issue-1047-1 branch 2 times, most recently from f803718 to 12e28e9 Compare March 23, 2026 09:42
@c0rydoras c0rydoras force-pushed the fix/backend/issue-1047-1 branch from 12e28e9 to d076721 Compare March 23, 2026 09:44
derrabauke
derrabauke previously approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@derrabauke derrabauke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (frontend)

PS: some test seems to fail thou

@c0rydoras
chore(backend): remove verifying from a notifications test
51c942b 
Instead of, now verifying in a seperate request, it makes more sense to drop this as it has no impact on what is being tested
@c0rydoras c0rydoras enabled auto-merge (squash) March 23, 2026 10:28
@c0rydoras c0rydoras merged commit 3ec0b9a into adfinis:main Mar 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@open-dynaMIX open-dynaMIX open-dynaMIX approved these changes

@derrabauke derrabauke derrabauke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Comment Box & History Record when moving a Timed Entry to a different task, project or customer

3 participants

@c0rydoras @open-dynaMIX @derrabauke