Skip to content

feat: reason/comment field for reviewing reports#1126

Merged
c0rydoras merged 1 commit intoadfinis:mainfrom
c0rydoras:fix/backend/issue-1047-2
Mar 30, 2026
Merged

feat: reason/comment field for reviewing reports#1126
c0rydoras merged 1 commit intoadfinis:mainfrom
c0rydoras:fix/backend/issue-1047-2

Conversation

@c0rydoras
Copy link
Copy Markdown
Collaborator

@c0rydoras c0rydoras commented Mar 23, 2026

No description provided.

@c0rydoras c0rydoras changed the title draft: reason/comment field for reviewing reports feat: reason/comment field for reviewing reports Mar 23, 2026
@c0rydoras c0rydoras requested a review from open-dynaMIX March 23, 2026 14:43
Copy link
Copy Markdown
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A few remarks remain - more suggestions than hard requirements, but check them out and see which variant is more readable (reviewed backend only)

Comment thread backend/timed/tracking/tests/test_report.py Outdated
Comment thread backend/timed/tracking/views.py Outdated
Comment thread backend/timed/tracking/tests/test_report.py
Comment thread backend/timed/tracking/tasks.py
Comment thread backend/timed/tracking/views.py Outdated
Comment thread frontend/app/analysis/edit/template.hbs Outdated
derrabauke
derrabauke previously approved these changes Mar 23, 2026
Copy link
Copy Markdown
Member

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tiny question regarding the label, otherwise lgtm 🎉

@c0rydoras c0rydoras force-pushed the fix/backend/issue-1047-2 branch from 19350be to 610bcae Compare March 30, 2026 07:48
Copy link
Copy Markdown
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a few things left to do, otherwise LGTM now

Comment thread backend/timed/tracking/views.py Outdated
Comment thread backend/timed/tracking/tests/test_report.py Outdated
@c0rydoras c0rydoras force-pushed the fix/backend/issue-1047-2 branch from 4520460 to cb65306 Compare March 30, 2026 09:35
@c0rydoras c0rydoras marked this pull request as ready for review March 30, 2026 09:36
@c0rydoras c0rydoras requested review from a team as code owners March 30, 2026 09:36
Copy link
Copy Markdown
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for addressing the feedback

@c0rydoras c0rydoras merged commit 3909b5a into adfinis:main Mar 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Comment Box & History Record when moving a Timed Entry to a different task, project or customer

3 participants