Draft
Conversation
c0rydoras
commented
Mar 30, 2026
32b77ad to
8331141
Compare
223d27a to
916dd13
Compare
1 task
40ba8df to
98e0e09
Compare
| """ | ||
|
|
||
| comment = models.TextField(blank=True) | ||
| report = models.ForeignKey(Report, on_delete=models.CASCADE, related_name="history") |
Member
There was a problem hiding this comment.
In many projects we use django-simple-history. The common pattern there is to have the history manager accessible via Model.history(). If we ever decide to introduce django-simple-history in this project, the history keyword is already used. Consider naming it something different, like log.
36a104c to
0879d08
Compare
0879d08 to
80e52a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what is implemented:
includewhat is currently missing: