trim carriage-return at the end of signature comments#8
Merged
Conversation
This commit fixes a bug when parsing minisign signatures.
Before, any carriage return ('\r') at the end of a
trusted / untrusted comment was not removed. This lead to
signature verification failures. In particular, the verification
of the comment signature fails when e.g. the OS uses `\r\n` for
newlines instead of `\n`.
Byte representation of a trusted comment - with and without the
trailing carriage return.
```
[116 105 109 101 115 116 97 109 112 58 49 54 49 55 55 50 49 48 50 51 9 102 105 108 101 58 114 111 98 116 101 115 116 46 112 115 49 13]
[116 105 109 101 115 116 97 109 112 58 49 54 49 55 55 50 49 48 50 51 9 102 105 108 101 58 114 111 98 116 101 115 116 46 112 115 49]
```
Fixes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug when parsing minisign signatures.
Before, any carriage return ('\r') at the end of a
trusted / untrusted comment was not removed. This lead to
signature verification failures. In particular, the verification
of the comment signature fails when e.g. the OS uses
\r\nfornewlines instead of
\n.Byte representation of a trusted comment - with and without the
trailing carriage return.
Fixes #7