feat(inkless): Support basic ListOffset for hybrid topics#577
Merged
Conversation
29aa501 to
e48118d
Compare
e48118d to
88b4004
Compare
viktorsomogyi
approved these changes
Apr 27, 2026
jeqo
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch offset for timestamp inside UnifiedLog for classic topics and classic topics still not migrated yet fully to diskless.
Migrated topics still fetch offsets through diskless, which is not correct but the correct routing will be implemented in a follow up PR.
Extract ListOffset logic for classic topics into its own method. This makes the logic reusable for the next changes necessary to support hybrid topics.