Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08a9078958
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| parser.add_argument( | ||
| '--output', | ||
| type=Path, | ||
| default=Path('benchmarks/summary.svg'), |
There was a problem hiding this comment.
Resolve default output relative to script
The default --output path is now Path('benchmarks/summary.svg'), which is interpreted relative to the current working directory instead of the script location. If someone runs the generator from inside benchmarks/ (for example, python3 plot.py while editing it), it now targets benchmarks/benchmarks/summary.svg and fails with FileNotFoundError, so chart regeneration becomes CWD-dependent; the previous behavior (Path(__file__).with_name(...)) did not have this regression.
Useful? React with 👍 / 👎.
Summary
Match the benchmark summary assets to the established TexSoup benchmark styling and naming.
What Changed
benchmarks/plot.pybenchmarks/summary.svgbenchmarks/README.mdto embedsummary.svg~/dev/TexSoup/benchmarks/plot.pyWhy
The prior follow-up used a custom dark-mode treatment and different asset names. This change brings the plot in line with the benchmark styling conventions already used in TexSoup.
Impact
Validation
python3 benchmarks/plot.pyxmllint --noout benchmarks/summary.svggit diff --check