Split benchmark chart into minification and compression#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh the benchmark summary figure so both panels focus on compression outcomes instead of mixing compression and runtime.
What Changed
Minificationwhile keeping the current minify-only data and layoutbenchmarks/README.mdbenchmarks/summary.svgfrombenchmarks/plot.pyWhy
The previous chart mixed two different dimensions: minify-only compression on the left and runtime on the right. This follow-up makes the figure compare two compression-oriented views side by side.
Impact
Validation
python3 benchmarks/plot.pyxmllint --noout benchmarks/summary.svggit diff --check