Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the faster compression profile the default for both the Python API and CLI, while keeping the slower full pipeline available as an explicit opt-in.
What Changed
minify()to default tofast=True--slowfor the full pipelinefast=Falseonly where they specifically validate the slower hoisting and aliasing passesWhy
The previous default paid a meaningful runtime cost for two optional passes that are not consistently beneficial. On the checked-in fixtures, the fast path is materially quicker, and the slower path is not reliably smaller on larger packages.
Impact
pyminiruns are faster without any flags--sloworfast=FalseValidation
.venv/bin/pytestbenchmarks/README.mdNotes
The slower profile still helps some smaller or targeted inputs, but it can also produce slightly larger output on fixtures like
clickandpytest, so the PR avoids presenting it as a universal "best compression" mode.