feat: enable command borders and report by default#4632
Open
cidrblock wants to merge 2 commits intoansible:mainfrom
Open
feat: enable command borders and report by default#4632cidrblock wants to merge 2 commits intoansible:mainfrom
cidrblock wants to merge 2 commits intoansible:mainfrom
Conversation
Promote --command-borders and --report from experimental flags (default: disabled) to stable features (default: enabled). Users who prefer the old behavior can pass --no-command-borders or --no-report, or set the MOLECULE_COMMAND_BORDERS=false / MOLECULE_REPORT=false environment variables. - Change default from False to True for both options in click_cfg.py - Remove experimental=True so help text no longer shows EXPERIMENTAL prefix - Update fallback defaults in config.py and base.py to match - Update all affected unit tests for new defaults and sort order - Remove redundant --report --command-borders from doc examples Made-with: Cursor
Move report and command_borders from the experimental_options list to the non_experimental_options list in the test, matching the change to remove their experimental flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--command-bordersand--reportfrom experimental flags (default: disabled) to stable features (default: enabled).EXPERIMENTAL:prefix from their help text and re-sort them into the standard options section.config.pyandbase.pyto match the new Click defaults.--report --command-bordersfrom all doc examples across 3 files (~38 commands).Users who prefer the old behavior can pass
--no-command-borders/--no-report, or setMOLECULE_COMMAND_BORDERS=false/MOLECULE_REPORT=false.Test plan
molecule testshows command borders and report by default (no flags needed)molecule test --no-command-borders --no-reportdisables both featuresMOLECULE_REPORT=false MOLECULE_COMMAND_BORDERS=false molecule testdisables both via envpython -m pytest tests/unit/command/test_base.py -vto confirm env/CLI precedence tests passpython -m pytest tests/unit/test_click_cfg.py -vto confirm option metadata and sort order tests passpython -m pytest tests/unit/dependency/ -vto confirm dependency tests pass with new defaultsMade with Cursor