Skip to content

[Issue-211] #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arainko merged 2 commits into from
Oct 13, 2024
Merged

[Issue-211] #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bf9391
Maybeeeeeeeeeeee a fix for #211
arainko Oct 13, 2024
fddd11c
clean up the fix
arainko Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ducktape/src/main/scala/io/github/arainko/ducktape/internal/Plan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,12 @@ private[ducktape] object Plan {
Quotes,
Context
): Plan.Configured[F] =
(plan.source.tpe, plan.dest.tpe, conf.tpe) match {
case ('[src], '[dest], '[confTpe]) =>
val source = if instruction.side.isDest then Structure.Lazy.of[confTpe](plan.source.path) else plan.source
conf.tpe match {
case '[confTpe] =>
// if side is Source then we're operating on either a missing Source case or an override of that,
// which means the dest types need to be narrowed down to the exact type of this config
val dest = if instruction.side.isSource then Structure.Lazy.of[confTpe](plan.dest.path) else plan.dest
Plan.Configured(source, dest, conf, instruction.span)
Plan.Configured(plan.source, dest, conf, instruction.span)
}
}

Expand Down
2 changes: 1 addition & 1 deletion ducktape/src/main/scala/io/github/arainko/ducktape/internal/PlanInterpreter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ private[ducktape] object PlanInterpreter {
plan match {
case Plan.Upcast(_, _, _) => value

case Plan.Configured(_, _, config, _) =>
case Plan.Configured(_, dest, config, _) =>
evaluateConfig(config, value)

case Plan.BetweenProducts(sourceTpe, destTpe, fieldPlans) =>
Expand Down
24 changes: 24 additions & 0 deletions ducktape/src/test/scala/io/github/arainko/ducktape/issues/Issue211Suite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package io.github.arainko.ducktape.issues

import io.github.arainko.ducktape.*

class Issue211Suite extends DucktapeSuite {
test("directly configuring a Dest case doesn't fail at runtime") {
enum SourceLevel3 {
case One(int: Int)
case Two(str: String)
}

enum DestLevel3 {
case One(int: Long)
case Two(str: String)
}

val source = SourceLevel3.One(1)
val expected = DestLevel3.One(6)

assertTransformsConfigured(source, expected)(
Field.const(_.at[DestLevel3.One], DestLevel3.One(6L))
)
}
}