Support named tuples#284
Merged
arainko merged 4 commits intoseries/0.2.xfrom Aug 2, 2025
Merged
Conversation
arainko
commented
Aug 2, 2025
| type MirroredElemLabels = labels | ||
| type MirroredElemTypes = types | ||
| } | ||
| } if Type.of[A].repr.dealias.typeSymbol.fullName == "scala.NamedTuple$.NamedTuple" => |
Owner
Author
There was a problem hiding this comment.
clean this code duplication later on
Owner
Author
|
This doesn't support traversing named tuple fields in configs. It'll come in a follow-up PR |
arainko
commented
Aug 2, 2025
| case other => | ||
| Logger.debug(s"Matched an unexpected term") | ||
| report.errorAndAbort(s"Couldn't parse an unexpected config option: ${other.show(using Printer.TreeShortCode)}") | ||
| report.errorAndAbort(s"Couldn't parse an unexpected config option: ${other.show(using Printer.TreeStructure)}") |
Owner
Author
There was a problem hiding this comment.
make this a proper error message later on as well, this is user-scaring level of barf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.