Modifier, Prop, and HtmlAttr are Contravariant#169
Merged
armanbilge merged 4 commits intomainfrom Jan 27, 2023
Merged
Conversation
Merged
2chilled
approved these changes
Jan 27, 2023
Contributor
2chilled
left a comment
There was a problem hiding this comment.
Besides improved expressiveness, this makes clear we currently don't even try to understand html not produced by calico 😄
Owner
Author
is that a good thing? 😅 I think we should open an issue/discussion about this topic, since it keeps coming up :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following from #168 (comment). In this case it was more natural because the types already has the appropriate type parameters.
I finally had to kill
Codecsince codecs are not contravariant.