Merged
Conversation
|
Yeah. I think adding them to all the *.md code would hammer home the point that components are |
2chilled
approved these changes
Feb 13, 2023
| ) | ||
|
|
||
| app.renderInto(node.asInstanceOf[fs2.dom.Node[IO]]).allocated.unsafeRunAndForget() | ||
| app.renderInto(node.asInstanceOf[fs2.dom.Node[IO]]).useForever.unsafeRunAndForget() |
Contributor
There was a problem hiding this comment.
This asInstanceOf looks a bit "hacky", at least for people not knowing background story. It also kind of leaks the opaque type. Maybe we can hide that somehow.
Owner
Author
There was a problem hiding this comment.
Yeah, the unsafeRunAndForget() also is not so great 😅 maybe we can move these out of the code block 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And some other minor tidying.
Closes #189. @hejfelix were these the ones you were thinking, any others I should add to?