Raise helpful error if IOWebApp fails to mount#346
Merged
armanbilge merged 5 commits intoarmanbilge:mainfrom Jan 29, 2024
Merged
Raise helpful error if IOWebApp fails to mount#346armanbilge merged 5 commits intoarmanbilge:mainfrom
IOWebApp fails to mount#346armanbilge merged 5 commits intoarmanbilge:mainfrom
Conversation
Contributor
Author
|
With this change IOWebapp will throw an error if proper div is not found in the html which is used to load the scalajs application. |
armanbilge
reviewed
Jan 29, 2024
Contributor
Author
|
Fixed the error message. |
armanbilge
reviewed
Jan 29, 2024
IOWebApp fails to mount
armanbilge
approved these changes
Jan 29, 2024
Owner
armanbilge
left a comment
There was a problem hiding this comment.
Thanks a lot! I can't believe I left a raw map(_.get) there 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error messages during initialization will help beginners falling into trouble.