Place a bound on how many auth attempts will be tried#485
Merged
Conversation
non
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the authentication flow will retry indefinitely if the registry includes authentication challenges in its 403 responses and the user has proper credentials but insufficient privileges to perform the action.
Solution
Fail the request after a number of authentication attempts. We allow at least 3 auth attempts (since the code path will always initially attempt a request without auth before invoking an auth helper) but otherwise respect the configured
retriesparameter.Testing
A did a release of this code on my fork of the repo, and patched the puller into a work build, and verified that a path that previously would hang when trying to do a push now fails with a reasonable error message: