Skip to content

Drop auth_info on redirect #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklukas merged 1 commit into from
Jan 29, 2025
+7 −0
Merged

Drop auth_info on redirect #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/registry/http/http_cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,13 @@ impl HttpCli {
)
})?;
}
// We drop existing auth info since this may conflict with auth for the
// redirected destination. In particular, a redirect to blobs in S3 may
// include X-Amz-* query parameters in the URL that cannot be used in
// conjunction with an Authentication header.
let mut ai = self.auth_info.lock().await;
*ai = None;
drop(ai);
continue;
}
RequestFailType::ConnectError(_) => continue,
Expand Down