You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prettier preserves at most 1 empty line (2 newlines) between tags. This PR makes it so that Biome matches the newline preserving behavior of Prettier.
It feels a bit hacky, but it gets the job done. Since this was originally ported from the JsxChildList behavior, this code makes a bunch of assumptions about the parsing that are not true for the HTML parser. Planning to go through it eventually to clean it up and simplify it, which will be a lot easier to do when we have sufficient tests.
Caution
This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.
dyc3
changed the title
fix(format/hml): keep at most 1 empty line between elements
fix(format/html): keep at most 1 empty line between elements
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prettier preserves at most 1 empty line (2 newlines) between tags. This PR makes it so that Biome matches the newline preserving behavior of Prettier.
It feels a bit hacky, but it gets the job done. Since this was originally ported from the
JsxChildListbehavior, this code makes a bunch of assumptions about the parsing that are not true for the HTML parser. Planning to go through it eventually to clean it up and simplify it, which will be a lot easier to do when we have sufficient tests.Caution
This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.
fixes #3973
Test Plan
Added a few tests.