chore: add governance changes approval#4943
Merged
Conversation
dyc3
approved these changes
Jan 22, 2025
nhedger
reviewed
Jan 22, 2025
nhedger
approved these changes
Jan 22, 2025
arendjr
reviewed
Jan 22, 2025
Contributor
arendjr
left a comment
There was a problem hiding this comment.
I would prefer changes to require a majority of leads rather than just a single one. It feels as if decisions could be rushed otherwise.
Co-authored-by: Nicolas Hedger <[email protected]>
Co-authored-by: Arend van Beelen jr. <[email protected]>
fireairforce
approved these changes
Jan 23, 2025
unvalley
approved these changes
Jan 23, 2025
arendjr
approved these changes
Jan 23, 2025
Conaclos
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the following changes to the Governance document:
Test Plan
Proof read and wait for the 50% approval from core contributors