⚠️ No Changeset found

Latest commit: 64b3bba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CodSpeed Performance Report

Merging #6894 will not alter performance

_{Comparing arendjr:upgrade-schemars (64b3bba) with main (b7e2d4d)}

Summary

✅ 114 untouched benchmarks

All the failures are coming from our assertions in our codegen. I think that the openapi schema setting considers optional things to be T | null rather than T?. I've seen other openapi generators do something like this because they set nullable to true, but in openapi, to make something "optional" (as in the key may not exist) you have to omit it from the required field on the object.

Thanks, seems that is indeed related. By ignoring the assertion it confirms indeed that types that were treated as someProperty?: someType have now become someProperty: someType | null.

But I see a lot of other things have broken as well... going to park it for now. Hopefully we can finish it at some point.

The includes types aren't emitted anymore: https://github.com/arendjr/biome/blob/upgrade-schemars/packages%2F%40biomejs%2Fbackend-jsonrpc%2Fsrc%2Fworkspace.ts#L120-L123 (there's more than one instance)

Yeah, I know. That’s only one of the many issues…

That's been implemented