fix: revive wasm build#7136
Merged
siketyan merged 1 commit intobiomejs:nextfrom Aug 6, 2025
Merged
Conversation
|
Contributor
WalkthroughThe change shifts the instantiation of the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Scanner
participant ScanContext
participant scan_folder
Caller->>Scanner: scan()
Scanner->>ScanContext: instantiate ctx
Scanner->>scan_folder: pass &ctx
scan_folder-->>Scanner: scan results
Scanner-->>Caller: return results
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3)**/*.{rs,toml}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
crates/biome_*/**/*📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
**/*.rs📄 CodeRabbit Inference Engine (CONTRIBUTING.md)
Files:
🧠 Learnings (11)📓 Common learnings📚 Learning: applies to crates/biome_service/src/workspace_watcher.rs : keep the workspace state in sync with the...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : when banning certain functions o...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : avoid deep indentation by using ...Applied to files:
📚 Learning: applies to crates/biome_formatter/**/context.rs : define the `htmlformatcontext` type inside a file ...Applied to files:
📚 Learning: applies to crates/biome_parser/crates/biome_*/src/generated/ : create a `generated/` folder inside t...Applied to files:
📚 Learning: applies to crates/biome_service/src/workspace/watcher.tests.rs : add tests for watcher workspace met...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : new rules must be placed inside ...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : when a rule requires semantic in...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_*/lib/src/lint/nursery/*.rs : avoid unnecessary string allocat...Applied to files:
📚 Learning: applies to crates/biome_analyze/biome_rule_options/lib/*.rs : use boxed slices (`box<[box]>`) i...Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
ematipico
approved these changes
Aug 6, 2025
Contributor
|
Sorry about that! It’s not the first time I’ve broken the playground 😬 How can I better check if it still works? |
Member
Author
|
@arendjr No worries! It was a build failure this time, so I noticed from a failed workflow notification (https://github.com/biomejs/biome/actions/runs/16779123934). For runtime issues, we could run Playwright tests before merging the sync PR, adding more tests :) |
ematipico
pushed a commit
that referenced
this pull request
Aug 12, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed broken WASM build after #6989.
Test Plan
Will be synced to next.biomejs.dev/playground so we can try there
Docs
N/A