crates/biome_test_utils/src/lib.rs (1)

205-213: Panic output: include path and truncate the source to keep CI readable

Great idea to show the source on parse failures. Two tweaks:

• Include the file path in the message.
• Truncate very long content to avoid log spam.

Apply this diff:

                 let parsed =
                     biome_js_parser::parse(&content, file_source, JsParserOptions::default());
                 let diagnostics = parsed.diagnostics();
+                // Keep logs readable if the file is huge
+                let mut display_content = content.clone();
+                if display_content.len() > 8 * 1024 {
+                    display_content.truncate(8 * 1024);
+                    display_content.push_str("… [truncated]");
+                }
                 assert!(
                     diagnostics.is_empty(),
-                    "Unexpected diagnostics: {diagnostics:?}\nWhile parsing:\n{content}"
+                    "Unexpected diagnostics while parsing {path}:\n{diagnostics:?}\n\nSource:\n{display_content}"
                 );
                 parsed.try_tree()

crates/biome_js_analyze/src/lint/correctness/no_undeclared_dependencies.rs (2)

46-61: Docs: valid example covers key exemptions

Good coverage of declared dep, Node built‑ins, relative import, and an alias.
Small nit: consider also showing an '@/components' example since it’s mentioned above.

---

87-120: Docs: devDependencies example reads well; broaden the glob?

Looks great and exercises multi‑file. You might want **/tests/**/*.test.js to cover nested suites.

xtask/rules_check/src/lib.rs (2)

228-233: Normalise file= paths more robustly (absolute, backslashes, leading slashes)

Current logic can yield paths like ///index.js if the author writes file=/index.js, and it doesn’t handle Windows backslashes. Normalise once and ensure a single leading slash.

Apply this diff:

-                let path = file
-                    .trim_start_matches("./")
-                    .trim_start_matches("../")
-                    .trim();
-                test.file_path = Some(format!("/{path}"));
+                let normalized = file
+                    .trim()
+                    .replace('\\', "/");
+                let normalized = normalized
+                    .trim_start_matches("./")
+                    .trim_start_matches("../")
+                    .trim_start_matches('/');
+                test.file_path = Some(format!("/{}", normalized));

---

967-1018: Harden manifest ingestion: surface JSON errors and don’t panic on unknown manifests

Two refinements for resilience and debuggability:

• If manifest parsing fails, panic with a helpful message (so docs break loudly and early).
• Replace unimplemented! for unknown manifests with a continue (ignore gracefully).

Apply this diff:

         if biome_path.is_manifest() {
             match biome_path.file_name() {
                 Some("package.json") => {
-                    let parsed = parse_json(src, JsonParserOptions::default());
+                    let parsed = parse_json(src, JsonParserOptions::default());
+                    if parsed.has_errors() {
+                        panic!("Failed to parse manifest {} (package.json) in test files", path_buf);
+                    }
                     layout.insert_serialized_node_manifest(
                         path_buf.parent().unwrap().into(),
                         &parsed.syntax().as_send().unwrap(),
                     );
                 }
                 Some("tsconfig.json") => {
-                    let parsed = parse_json(
+                    let parsed = parse_json(
                         src,
                         JsonParserOptions::default()
                             .with_allow_comments()
                             .with_allow_trailing_commas(),
                     );
+                    if parsed.has_errors() {
+                        panic!("Failed to parse manifest {} (tsconfig.json) in test files", path_buf);
+                    }
                     layout.insert_serialized_tsconfig(
                         path_buf.parent().unwrap().into(),
                         &parsed.syntax().as_send().unwrap(),
                     );
                 }
-                _ => unimplemented!("Unhandled manifest: {biome_path}"),
+                _ => continue,
             }
         } else {
             added_paths.push(biome_path);
         }

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Use helper advice types from biome_diagnostics::v2 (CodeFrameAdvice, CommandAdvice, DiffAdvice, LogAdvice) when suitable

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Types implementing Diagnostic must also implement Debug (e.g., use #[derive(Debug, Diagnostic)])

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-09-05T06:39:46.267Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/*.rs : Code blocks in rule docs must specify a language; invalid examples use `,expect_diagnostic` and must emit exactly one diagnostic; use `ignore` sparingly

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-09-05T06:39:46.267Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/*.rs : When showing rule-specific configuration in docs, use `json`/`jsonc` with `,options` (or `,full_options` for full biome.json); follow the modifier order `<lang>[,expect_diagnostic][,(options|full_options|use_options)][,ignore][,file=path]`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-09-05T06:39:46.267Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/*.rs : Rule documentation (Rust doc comments) must start with a single-line summary, include `## Examples` with `### Invalid` first then `### Valid`, and document options under `## Options`

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-09-05T06:39:46.267Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/*.rs : Set the `language` field in `declare_lint_rule!` appropriately (js, jsx, ts, tsx)

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-09-05T06:39:46.267Z
Learning: Applies to crates/biome_analyze/crates/**/lib/src/**/*.rs : In `declare_lint_rule!`, set `version: "next"` for new or changing rules