fix(lint/style/noDescendingSpecificity): limit the `noDescendingSpecificity` rule to selectors within the same `@layer` by ryumasai · Pull Request #7618 · biomejs/biome

ryumasai · 2025-09-30T05:14:44Z

Summary

Closes #7533

The noDescendingSpecificity rule now only compares specificity selectors that belong to the same @layer.

Test Plan

snaptests

Docs

rustdoc and changeset

changeset-bot · 2025-09-30T05:14:49Z

🦋 Changeset detected

Latest commit: 7ff777f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…ficity` rule to selectors within the same `@layer`

coderabbitai · 2025-09-30T05:18:19Z

Walkthrough

This PR makes the style/noDescendingSpecificity lint layer-aware by recording an optional AnyCssLayer with visited selectors and reporting descending-specificity only when selectors are in the same cascade layer. It adds Selector::layer() to the semantic model to find the nearest @layer ancestor, updates the lint implementation and docs, extends tests with @layer cases, and adds a changeset bump for @biomejs/biome.

Possibly related PRs

fix(noDescendingSpecificity): compute nested selectors #7358 — Also modifies the noDescendingSpecificity lint and selector/semantic-model handling to refine context-aware specificity checks.

Suggested labels

A-Parser

Suggested reviewers

ematipico

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly identifies the specific lint rule being fixed and clearly states the primary change of scoping `noDescendingSpecificity` to selectors within the same `@layer`, making it both concise and relevant to the main changeset.
Linked Issues Check	✅ Passed	The pull request fully implements the objectives from issue #7533 by adding layer‐aware comparisons in the lint rule, updating documentation, and including tests for layered contexts, matching the requested behaviour.
Out of Scope Changes Check	✅ Passed	All modifications are confined to scoping the `noDescendingSpecificity` rule within the same `@layer` context, adding the necessary helper, tests and docs, without introducing any unrelated functionality.
Description Check	✅ Passed	The description directly relates to the changeset by summarising the fix for the lint rule, referencing the linked issue, and outlining the test plan and documentation updates, so it clearly describes the PR’s purpose.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0f66f1 and 7ff777f.

⛔ Files ignored due to path filters (3)

crates/biome_configuration/src/analyzer/linter/rules.rs is excluded by !**/rules.rs and included by **
packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

📒 Files selected for processing (1)

crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs (7 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/**

📄 CodeRabbit inference engine (CLAUDE.md)

Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}

Files:

crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs

crates/biome_*/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place core crates under /crates/biome_*/

Files:

crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Format all Rust source files before committing (just f)

Files:

crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs

🧠 Learnings (1)

📚 Learning: 2025-09-10T08:05:22.867Z

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-09-10T08:05:22.867Z
Learning: Applies to crates/biome_analyze/**/src/{lint,assist}/**/*.rs : Code blocks in rule docs must specify language; invalid snippets require `expect_diagnostic`; use `options`/`full_options`/`use_options` markers as appropriate

Applied to files:

crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (26)

GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: End-to-end tests
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Check Dependencies
GitHub Check: Documentation
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check JS Files
GitHub Check: Test Node.js API
GitHub Check: Bench (biome_json_parser)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_module_graph)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_html_parser)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_package)
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Bench (biome_html_formatter)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_configuration)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Bench (biome_css_parser)
GitHub Check: autofix

🔇 Additional comments (6)

crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs (6)

1-1: LGTM!

The import is necessary for the layer-aware comparisons.

17-17: Documentation accurately reflects layer-scoped behavior.

The description now correctly states the rule only applies within the same layer.

56-106: Examples correctly demonstrate layer-aware behavior.

The invalid example (lines 56-62) correctly shows that descending specificity within a single @layer is still an error, whilst the valid example (lines 93-106) demonstrates that across different layers the rule does not apply. The expect_diagnostic marker is now present as required.

Note: The past review comment regarding the missing expect_diagnostic marker has been addressed.

153-153: Type extension correctly includes layer information.

The tuple now stores Option<AnyCssLayer> to track which layer each selector belongs to.

179-179: Insertion correctly stores layer information.

The tuple now includes selector.layer() to track the layer context for future comparisons.

167-170: Approve code changes. The condition now correctly restricts descending specificity checks to selectors in the same layer.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

Public repositories are always opted into early access features.
You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

.changeset/puny-needles-eat.md (1)

5-5: Consider adjusting tense for clarity.

The changeset mixes "Fixed" (past tense) with "now only compares" (present tense). Per the coding guidelines, describe what you did in past tense and current behaviour in present tense separately for clarity.

Suggested rephrase:

-Fixed [#7533](https://github.com/biomejs/biome/issues/7533): the `noDescendingSpecificity` rule now only compares specificity selectors that belong to the same `@layer`.
+Fixed [#7533](https://github.com/biomejs/biome/issues/7533): Updated the `noDescendingSpecificity` rule to compare specificity only for selectors within the same `@layer`. The rule now correctly ignores specificity differences across different layers.

Or more concisely:

-Fixed [#7533](https://github.com/biomejs/biome/issues/7533): the `noDescendingSpecificity` rule now only compares specificity selectors that belong to the same `@layer`.
+Fixed [#7533](https://github.com/biomejs/biome/issues/7533): Made the `noDescendingSpecificity` rule layer-aware. It now only compares specificity for selectors within the same `@layer`.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b9b9d8 and 4883ec9.

⛔ Files ignored due to path filters (2)

crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/complex_selector.invalid.css.snap is excluded by !**/*.snap and included by **
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/valid.css.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (5)

.changeset/puny-needles-eat.md (1 hunks)
crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs (7 hunks)
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/complex_selector.invalid.css (1 hunks)
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/valid.css (1 hunks)
crates/biome_css_semantic/src/semantic_model/model.rs (2 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/**

📄 CodeRabbit inference engine (CLAUDE.md)

Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}

Files:

crates/biome_css_semantic/src/semantic_model/model.rs
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/valid.css
crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/complex_selector.invalid.css

crates/biome_*/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place core crates under /crates/biome_*/

Files:

crates/biome_css_semantic/src/semantic_model/model.rs
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/valid.css
crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/complex_selector.invalid.css

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Format all Rust source files before committing (just f)

Files:

crates/biome_css_semantic/src/semantic_model/model.rs
crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs

.changeset/*.md

📄 CodeRabbit inference engine (CONTRIBUTING.md)

.changeset/*.md: In changeset files, only use #### or ##### headers; avoid other header levels
Changeset descriptions should use past tense for what you did (e.g., "Added...")
Describe current Biome behavior in present tense within changesets (e.g., "Biome now supports...")
For bug fixes in changesets, start with a link to the issue (e.g., "Fixed #1234: ...")
When referencing rules or assists in changesets, include links to their documentation pages
Include a minimal code block in the changeset when applicable to demonstrate the change
End every sentence in the changeset description with a period

Files:

.changeset/puny-needles-eat.md

**/tests/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place test files under a tests/ directory in each crate

Files:

crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/valid.css
crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/complex_selector.invalid.css

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)

GitHub Check: Bench (biome_module_graph)
GitHub Check: autofix
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_html_parser)
GitHub Check: Bench (biome_json_parser)
GitHub Check: Bench (biome_configuration)
GitHub Check: Bench (biome_html_formatter)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_package)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_css_parser)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Bench (biome_js_formatter)
GitHub Check: Documentation
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check Dependencies
GitHub Check: Test Node.js API
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)

🔇 Additional comments (9)

crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/complex_selector.invalid.css (1)

10-18: Good test coverage for within-layer violations.

This test case properly exercises the rule's behaviour within a single @layer block, ensuring descending specificity is still caught when selectors are in the same layer.

crates/biome_css_semantic/src/semantic_model/model.rs (2)

1-5: LGTM.

Import correctly adds AnyCssLayer for the new layer() method.

238-245: LGTM.

The ancestor walk correctly returns the nearest enclosing @layer for a selector. For nested layers, this returns the innermost layer, which aligns with CSS cascade layer semantics.

crates/biome_css_analyze/tests/specs/style/noDescendingSpecificity/valid.css (1)

54-72: Excellent test coverage for cross-layer scenarios.

These test cases properly verify that selectors with descending specificity across different @layer blocks are correctly exempted from the rule. The nested @layer three also exercises nested layer handling.

crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs (5)

1-1: LGTM.

Import correctly adds AnyCssLayer for layer-aware comparison logic.

93-106: LGTM.

This example clearly demonstrates the cross-layer exemption, showing that b a in @layer base and a in @layer special are correctly treated as independent despite descending specificity.

153-154: LGTM.

Data structure correctly extended to track layer context alongside specificity.

177-181: LGTM.

Insertion correctly stores layer context alongside range and specificity for subsequent comparisons.

167-180: Could you run the analyzer on /tmp/test_same_layer_name.css and share whether it flags the descending specificity across the two @layer base blocks?

codspeed-hq · 2025-09-30T05:25:42Z

CodSpeed Performance Report

Merging #7618 will not alter performance

_{Comparing qraqras:dev/7533 (7ff777f) with main (2b9b9d8)}

Summary

✅ 133 untouched

ryumasai · 2025-09-30T05:45:51Z

Everything is ready.

github-actions Bot added A-Linter Area: linter L-CSS Language: CSS and super languages labels Sep 30, 2025

fix(lint/style/noDescendingSpecificity): limit the `noDescendingSpeci…

a0f66f1

…ficity` rule to selectors within the same `@layer`

coderabbitai Bot reviewed Sep 30, 2025

View reviewed changes

Comment thread crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs Outdated

ryumasai force-pushed the dev/7533 branch from 4883ec9 to a0f66f1 Compare September 30, 2025 05:18

ryumasai changed the title ~~fix(lint/style/noDescendingSpecificity): Limit the noDescendingSpecificity rule to selectors within the same @layer~~ fix(lint/style/noDescendingSpecificity): limit the noDescendingSpecificity rule to selectors within the same @layer Sep 30, 2025

[autofix.ci] apply automated fixes

baa02bf

github-actions Bot added the A-Project Area: project label Sep 30, 2025

add expect_diagnostic

7ff777f

ryumasai closed this Oct 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(lint/style/noDescendingSpecificity): limit the `noDescendingSpecificity` rule to selectors within the same `@layer`#7618

fix(lint/style/noDescendingSpecificity): limit the `noDescendingSpecificity` rule to selectors within the same `@layer`#7618
ryumasai wants to merge 3 commits intobiomejs:mainfrom
ryumasai:dev/7533

ryumasai commented Sep 30, 2025

Uh oh!

changeset-bot Bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

ryumasai commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ryumasai commented Sep 30, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #7618 will not alter performance

Summary

Uh oh!

ryumasai commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot Bot commented Sep 30, 2025 •

edited

Loading

coderabbitai Bot commented Sep 30, 2025 •

edited

Loading

codspeed-hq Bot commented Sep 30, 2025 •

edited

Loading