crates/biome_js_analyze/tests/specs/style/useReactFunctionComponents/valid.jsx (1)

27-33: Good test case, but consider testing exported class expressions as well.

The test validates the fix for non-exported class expressions. Consider adding another test case for exported class expressions to ensure comprehensive coverage:

export const ExportedErrorBoundary = class extends React.Component {
  componentDidCatch(error, errorInfo) {}
  render() {
    return this.props.children;
  }
}

crates/biome_js_analyze/src/lint/style/use_react_function_components.rs (1)

118-133: Fix works correctly, but consider extracting the duplicate member-checking logic.

The logic correctly handles class expressions assigned to variables. However, the pattern for checking if a member is named "componentDidCatch" is now duplicated across three branches (lines 96-106, 109-116, and 123-130).

Consider extracting a helper function:

fn has_method_named(members: impl Iterator<Item = impl AstNode>, method_name: &str) -> bool {
    members.any(|member| {
        member
            .name()
            .ok()
            .flatten()
            .and_then(|name| name.name())
            .is_some_and(|name| name.text() == method_name)
    })
}

Then use it in all three branches:

JsClassDeclaration(js_class_declaration) => {
    has_method_named(js_class_declaration.members().iter(), "componentDidCatch")
}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro