Skip to content

fix: next namespace#8142

Merged
Netail merged 3 commits intobiomejs:mainfrom
Netail:fix/next-namespace
Nov 17, 2025
Merged

fix: next namespace#8142
Netail merged 3 commits intobiomejs:mainfrom
Netail:fix/next-namespace

Conversation

@Netail
Copy link
Copy Markdown
Member

@Netail Netail commented Nov 17, 2025 •
edited
Loading

Summary

Yeah, @next/next/ instead of @next/

https://nextjs.org/docs/app/api-reference/config/eslint#rules

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc08fd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the A-Linter Area: linter label Nov 17, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 17, 2025 •
edited
Loading

Walkthrough

The RuleSource::to_namespaced_rule_name function has been updated to change the namespace prefix for ESLint Next rules from "@next/{rule_name}" to "@next/next/{rule_name}". This affects how Next.js ESLint plugin rules are identified and referenced throughout the codebase. No other rule sources or function signatures are modified.

Possibly related PRs

Suggested labels

L-JavaScript

Suggested reviewers

  • dyc3

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the Next.js ESLint rule namespace from '@next/' to '@next/next/'.
Description check ✅ Passed The description is directly related to the changeset, referencing the namespace correction and linking to official Next.js documentation.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 803a44a and 161676a.

📒 Files selected for processing (1)
  • crates/biome_analyze/src/rule.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Check Dependencies
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Documentation
  • GitHub Check: autofix
  • GitHub Check: Test Node.js API
🔇 Additional comments (1)
crates/biome_analyze/src/rule.rs (1)

317-317: The namespace change is correct and complete.

The web search confirms the correct ESLint rule namespace format for @next/eslint-plugin-next is @next/next/, and the codebase search shows no other code relies on the old @next/ format for rules—only the display name at line 191 (which correctly shows the package name). No test files reference the namespace, so there's nothing else to update. Ship it.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining why this PR is needed, why this solution was chosen, and what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the A-CLI Area: CLI label Nov 17, 2025
@Netail Netail merged commit 1fbdff5 into biomejs:main Nov 17, 2025
13 checks passed
@Netail Netail deleted the fix/next-namespace branch November 17, 2025 21:28
l0ngvh pushed a commit to l0ngvh/biome that referenced this pull request Dec 21, 2025
@Netail @autofix-ci @l0ngvh
fix: next namespace (biomejs#8142)
b664211 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Netail @ematipico