fix(plugins): normalize relative plugin paths during config loading by JacquesLeupin · Pull Request #8524 · biomejs/biome

JacquesLeupin · 2025-12-20T16:08:56Z

Summary

In monorepos where nested configurations use extends: "//", relative plugin paths declared in the root configuration could be resolved relative to the child configuration directory, causing plugin loading to fail with "Cannot read file." This is related to the extends: "//" behavior discussed in #8360.

This PR normalizes plugin paths relative to the directory of the configuration file that declares them so that merged configurations keep consistent plugin path semantics.

AI disclosure: I used AI assistance (Cursor / GPT) to explore the codebase and draft the fix and tests.

Test Plan

Added unit tests for plugin path normalization.
Added a regression test covering a monorepo where root config plugins are inherited by a child config using extends: "//".

Commands run:

cargo test -p biome_plugin_loader
cargo test -p biome_cli --test main -- cases::monorepo
cargo test -p biome_service
cargo fmt --check
cargo clippy -p biome_service -p biome_cli -p biome_plugin_loader -- -D warnings

Docs

No documentation changes are needed (bugfix only).

changeset-bot · 2025-12-20T16:09:00Z

🦋 Changeset detected

Latest commit: 7d98151

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-12-20T16:12:08Z

Walkthrough

Normalises plugin paths after configuration extends are applied so relative plugin paths are resolved against the configuration file directory (or the external resolution base if missing). The change adds Plugins::normalize_relative_paths(&mut self, base_dir: &Utf8Path) and invokes it after extends/migration for the main configuration and each override pattern, mutating plugin path entries in-place. Adds unit tests for path normalisation and an integration test verifying plugins from a root config apply when a child config extends it.

Possibly related PRs

fix: resolve plugin paths relative to config file when using extends #8365: Implements the same plugin-path normalisation fix with matching monorepo test coverage for extended configurations.
fix(cli): resolve configs from parent paths #8371: Related changes to configuration-path resolution around extends, including fixes for resolving relative extends.

Suggested reviewers

dyc3

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: normalizing relative plugin paths during configuration loading, which is the core fix for issue #8488.
Description check	✅ Passed	The description clearly relates to the changeset by explaining the bug fix, the issue it addresses, test coverage, and verification steps performed.

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e127306 and 7d98151.

⛔ Files ignored due to path filters (1)

crates/biome_cli/tests/snapshots/main_cases_monorepo/plugins_from_root_config_work_in_child_config_extends_root.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (2)

.changeset/cruel-clouds-crash.md
crates/biome_cli/tests/cases/monorepo.rs

🚧 Files skipped from review as they are similar to previous changes (2)

crates/biome_cli/tests/cases/monorepo.rs
.changeset/cruel-clouds-crash.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: Documentation
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: autofix
GitHub Check: Test Node.js API

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

deww400 · 2025-12-28T03:35:41Z

@dyc3 are you able to review this PR?

arendjr

I didn’t look into the code too deeply, but if tests are green and you can confirm the fix works, @deww400 , I think it may be good to go.

dyc3

LGTM

github-actions Bot added A-CLI Area: CLI A-Project Area: project labels Dec 20, 2025

JacquesLeupin force-pushed the fix/plugin-relative-paths-config-merge branch from e4d063a to e127306 Compare December 20, 2025 21:00

This comment has been minimized.

Sign in to view

fix(plugins): normalize relative plugin paths during config loading

7d98151

JacquesLeupin force-pushed the fix/plugin-relative-paths-config-merge branch from e127306 to 7d98151 Compare December 29, 2025 23:02

arendjr approved these changes Dec 30, 2025

View reviewed changes

dyc3 approved these changes Dec 30, 2025

View reviewed changes

dyc3 merged commit 17a6156 into biomejs:main Dec 30, 2025
13 checks passed

github-actions Bot mentioned this pull request Dec 30, 2025

ci: release #8507

Merged

This was referenced Feb 11, 2026

fix: resolve glob patterns relative to project root when extending #8519

Merged

revert(core): includes resolution #9092

Merged

coderabbitai Bot mentioned this pull request Feb 24, 2026

fix: resolve plugin paths from extended configs #9233

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(plugins): normalize relative plugin paths during config loading#8524

fix(plugins): normalize relative plugin paths during config loading#8524
dyc3 merged 1 commit intobiomejs:mainfrom
JacquesLeupin:fix/plugin-relative-paths-config-merge

JacquesLeupin commented Dec 20, 2025

Uh oh!

changeset-bot Bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

deww400 commented Dec 28, 2025

Uh oh!

arendjr left a comment

Uh oh!

dyc3 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

JacquesLeupin commented Dec 20, 2025

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

This comment has been minimized.

deww400 commented Dec 28, 2025

Uh oh!

arendjr left a comment

Choose a reason for hiding this comment

Uh oh!

dyc3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Dec 20, 2025 •

edited

Loading

coderabbitai Bot commented Dec 20, 2025 •

edited

Loading