Skip to content

chore: remove old unused options#8676

Merged
Netail merged 1 commit intobiomejs:mainfrom
Netail:chore/remove-old-options
Jan 4, 2026
Merged

chore: remove old unused options#8676
Netail merged 1 commit intobiomejs:mainfrom
Netail:chore/remove-old-options

Conversation

@Netail
Copy link
Copy Markdown
Member

@Netail Netail commented Jan 4, 2026

Summary

remove old unused options; reminisce from renamed or deleted rules

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 4, 2026

⚠️ No Changeset found

Latest commit: a90d3ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the A-Diagnostic Area: diagnostocis label Jan 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 4, 2026

Walkthrough

This PR removes seven empty rule option structs from the biome_rule_options crate: NoInvalidNewBuiltinOptions, NoNewSymbolOptions, NoUselessStringEscapesOptions, UseAnchorHrefOptions, UseGraphqlNamedlOperationsOptions, UseNamedOperationOptions, and UseShorthandArrayTypeOptions. Each of these unit-like types had no fields but carried serde derives and deserializable traits. The corresponding imports and attributes have been cleaned up as part of the deletions.

Possibly related PRs

Suggested labels

A-Project, A-Linter, A-Tooling, A-Diagnostic

Suggested reviewers

  • ematipico
  • Conaclos
  • dyc3

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main purpose of the changeset: removing obsolete option structs from rule configuration files.
Description check ✅ Passed The description relates to the changeset by explaining that old, unused options from renamed or deleted rules are being removed.
✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31a9bfe and a90d3ee.

⛔ Files ignored due to path filters (2)
  • crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
  • packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
📒 Files selected for processing (7)
  • crates/biome_rule_options/src/no_invalid_new_builtin.rs
  • crates/biome_rule_options/src/no_new_symbol.rs
  • crates/biome_rule_options/src/no_useless_string_escapes.rs
  • crates/biome_rule_options/src/use_anchor_href.rs
  • crates/biome_rule_options/src/use_named_graphql_operations.rs
  • crates/biome_rule_options/src/use_named_operation.rs
  • crates/biome_rule_options/src/use_shorthand_array_type.rs
💤 Files with no reviewable changes (7)
  • crates/biome_rule_options/src/use_shorthand_array_type.rs
  • crates/biome_rule_options/src/no_useless_string_escapes.rs
  • crates/biome_rule_options/src/no_invalid_new_builtin.rs
  • crates/biome_rule_options/src/use_named_graphql_operations.rs
  • crates/biome_rule_options/src/use_named_operation.rs
  • crates/biome_rule_options/src/use_anchor_href.rs
  • crates/biome_rule_options/src/no_new_symbol.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Check Dependencies
  • GitHub Check: Check JS Files
  • GitHub Check: Documentation
  • GitHub Check: End-to-end tests
  • GitHub Check: autofix
  • GitHub Check: Test Node.js API

Comment @coderabbitai help to get the list of available commands and usage tips.

@Netail Netail merged commit 7cdc118 into biomejs:main Jan 4, 2026
13 checks passed
@Netail Netail deleted the chore/remove-old-options branch January 4, 2026 16:13
baeseokjae pushed a commit to baeseokjae/biome that referenced this pull request Jan 6, 2026
@Netail @baeseokjae
chore: remove old unused options (biomejs#8676)
de765d9
@coderabbitai coderabbitai Bot mentioned this pull request Feb 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siketyan siketyan siketyan approved these changes

Assignees

No one assigned

Labels

A-Diagnostic Area: diagnostocis

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Netail @siketyan