You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This pull request extends the HTML syntax API with tag-name accessors and element introspection utilities. New tag_name() methods are added to HtmlSelfClosingElement, HtmlOpeningElement, and HtmlElement to retrieve element names. The AnyHtmlElement enum receives updated and new methods: name() is refactored to delegate to the corresponding tag_name() variants, closing_r_angle_token() provides access to closing angle tokens for standard HTML elements, and Svelte-specific utilities is_svelte_block() and as_svelte_block() enable type checking and conversion for Svelte blocks. Corresponding imports are updated to support these additions.
The title accurately describes the main change: adding helper methods to HTML syntax nodes for easier tag name extraction and other utilities.
Description check
✅ Passed
The description clearly explains the motivation (simplifying tag name extraction), mentions these helpers will be used in subsequent PRs, and references CI validation.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📝 Generate docstrings
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-ParserArea: parserL-HTMLLanguage: HTML and super languages
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds some useful helpers to HTML syntax nodes, mostly to make it easier to extract the tag name without a bunch of code.
These helpers will be used later in this stack of PRs.
Test Plan
CI should be green
Docs