Skip to content

fix(css-functions): add sibiling index, count as valid functions#8924

Merged
dyc3 merged 3 commits intobiomejs:mainfrom
tmohammad78:fix/sibling-index-css-functions
Jan 31, 2026
Merged

fix(css-functions): add sibiling index, count as valid functions#8924
dyc3 merged 3 commits intobiomejs:mainfrom
tmohammad78:fix/sibling-index-css-functions

Conversation

@tmohammad78
Copy link
Copy Markdown
Contributor

@tmohammad78 tmohammad78 commented Jan 31, 2026 •
edited by dyc3
Loading

Summary

This PR fixes this issue #8920, We just need to add those fn as valid functions.
Because it was hard for me to onboard on the project, I used Cursor to change.

fixed #8920

Test Plan

test was added

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 31, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 1166b2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added A-Linter Area: linter L-CSS Language: CSS and super languages labels Jan 31, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 31, 2026 •
edited
Loading

Walkthrough

This pull request adds two CSS function keywords, sibling-count and sibling-index, to the public FUNCTION_KEYWORDS list in crates/biome_css_analyze/src/keywords.rs. Tests were added to crates/biome_css_analyze/tests/specs/correctness/noUnknownFunction/valid.css using calc() with these functions for animation-delay. A changeset was added for a patch release noting support for the new functions. Changes are additive and no existing behaviour was removed or altered.

Suggested reviewers

  • dyc3
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: adding sibling-index and sibling-count as valid CSS functions to fix a known issue.
Description check ✅ Passed The description is related to the changeset, referencing the issue being fixed and mentioning that a test was added, though it's brief.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ematipico
Copy link
Copy Markdown
Member

ematipico commented Jan 31, 2026

Thank you @tmohammad78

Please restore our PR template. Add a changeset as per contribution guidelines

@tmohammad78
Copy link
Copy Markdown
Contributor Author

tmohammad78 commented Jan 31, 2026

Thank you @tmohammad78

Please restore our PR template. Add a changeset as per contribution guidelines

YW @ematipico , could you pls check it again?

dyc3
dyc3 approved these changes Jan 31, 2026
View reviewed changes
Comment thread .changeset/soft-peas-bow.md Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 31, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing tmohammad78:fix/sibling-index-css-functions (1166b2a) with main (7c96517)

Summary

✅ 29 untouched benchmarks
⏩ 126 skipped benchmarks1

Footnotes

  1. 126 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@dyc3 dyc3 merged commit 99b4cd1 into biomejs:main Jan 31, 2026
19 checks passed
@github-actions github-actions Bot mentioned this pull request Jan 30, 2026
Merged
@andre-lmarinho andre-lmarinho mentioned this pull request Jan 31, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter L-CSS Language: CSS and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

💅 sibling-index is a real CSS 'function'

3 participants

@tmohammad78 @ematipico @dyc3