fix(formatter): don't remove quotes when type memeber is new by fireairforce · Pull Request #8945 · biomejs/biome

fireairforce · 2026-02-02T07:34:49Z

Summary

closes: #8354

When type member contains new, don't remove the quotes around it:

Before:

// Input:
type X = {
    'new'(): string;
};

// Format Output:
type X = {
   new(): string;
}

After:

// Input:
type X = {
    'new'(): string;
};

// Format Output:
type X = {
   'new'(): string;
}

Test Plan

Add snapshot test case

Docs

changeset-bot · 2026-02-02T07:34:55Z

🦋 Changeset detected

Latest commit: dc3b257

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-02-02T07:40:00Z

Walkthrough

Adds a guard in LiteralStringNormaliser::normalise_type_member to prevent removing quotes when the raw content is the literal "new". The change integrates an is_new_keyword check into the existing can_remove_quotes logic so type members named new remain quoted. A TypeScript test was added to verify a quoted 'new'() member stays quoted and is not converted into a construct signature.

Suggested reviewers

ematipico

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(formatter): don't remove quotes when type memeber is new' accurately describes the main change—preventing quote removal for 'new' type members.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the fix with before/after examples and mentioning the added test case.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#8354` by implementing logic to preserve quotes for type members named 'new', preventing them from becoming construct signatures.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the issue: formatter logic update, test case addition, and changelog entry—no extraneous modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-8354

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In @.changeset/kind-cities-read.md:
- Line 5: Fix the typo in the changeset description by replacing the misspelled
word "memeber" with "member" in the .changeset/kind-cities-read.md content (the
line reading "Don't remove quotes when type memeber is new."). Ensure the
corrected sentence reads "Don't remove quotes when type member is new." and
commit the updated file.
- Line 16: The example output incorrectly turned the quoted method signature
into a property: replace the incorrect `'new()': string;` with the correct
quoted method signature `'new'(): string;` so the output preserves a method
named 'new' (with parentheses) rather than a property; update the example output
to match the original input signature `'new'(): string;` wherever the incorrect
`'new()': string;` appears.

coderabbitai · 2026-02-02T07:42:47Z

+"@biomejs/biome": patch
+---
+
+Fixed [#8354](https://github.com/biomejs/biome/issues/8354): Don't remove quotes when type memeber is new.


⚠️ Potential issue | 🟡 Minor

Typo: "memeber" should be "member".

📝 Proposed fix

-Fixed [`#8354`](https://github.com/biomejs/biome/issues/8354): Don't remove quotes when type memeber is new. +Fixed [`#8354`](https://github.com/biomejs/biome/issues/8354): Don't remove quotes when type member is new.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

Fixed [#8354](https://github.com/biomejs/biome/issues/8354): Don't remove quotes when type memeber is new.

Fixed [`#8354`](https://github.com/biomejs/biome/issues/8354): Don't remove quotes when type member is new.

🤖 Prompt for AI Agents

In @.changeset/kind-cities-read.md at line 5, Fix the typo in the changeset description by replacing the misspelled word "memeber" with "member" in the .changeset/kind-cities-read.md content (the line reading "Don't remove quotes when type memeber is new."). Ensure the corrected sentence reads "Don't remove quotes when type member is new." and commit the updated file.

codspeed-hq · 2026-02-02T07:47:58Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 95 skipped benchmarks¹

_{Comparing fix-8354 (dc3b257) with main (3ab203a)²}

95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (9dc99cc) during the generation of this report, so 3ab203a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

siketyan

Do you know is there any other keywords that cannot be dequoted?

fireairforce · 2026-02-02T09:09:15Z

Do you know is there any other keywords that cannot be dequoted?

Not sure, maybe constructor also? it seems that prettier will not dequote the case under ts type member key:

fireairforce · 2026-02-02T09:10:34Z

maybe we don't need to dequote all the keywords here? what do you think? @siketyan

ematipico · 2026-02-02T09:18:30Z

@fireairforce that's part of the known differences

https://biomejs.dev/formatter/differences-with-prettier/#prettier-doesnt-unquote-some-object-properties-that-are-valid-javascript-identifiers

fireairforce · 2026-02-02T09:37:47Z

@fireairforce that's part of the known differences

https://biomejs.dev/formatter/differences-with-prettier/#prettier-doesnt-unquote-some-object-properties-that-are-valid-javascript-identifiers

thanks for your remind~ so it will be better to just fix the new case here?

fix(formatter): don't remove quotes when type memeber is new

67a886b

github-actions Bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Feb 2, 2026

chore: add changeset

dc3b257

coderabbitai Bot reviewed Feb 2, 2026

View reviewed changes

siketyan approved these changes Feb 2, 2026

View reviewed changes

fireairforce merged commit fa66fe3 into main Feb 2, 2026
17 checks passed

fireairforce deleted the fix-8354 branch February 2, 2026 12:23

github-actions Bot mentioned this pull request Feb 2, 2026

ci: release #8888

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(formatter): don't remove quotes when type memeber is new#8945

fix(formatter): don't remove quotes when type memeber is new#8945
fireairforce merged 2 commits intomainfrom
fix-8354

fireairforce commented Feb 2, 2026

Uh oh!

changeset-bot Bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Feb 2, 2026

Uh oh!

Uh oh!

codspeed-hq Bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

siketyan left a comment

Uh oh!

fireairforce commented Feb 2, 2026

Uh oh!

fireairforce commented Feb 2, 2026 •

edited

Loading

Uh oh!

ematipico commented Feb 2, 2026

Uh oh!

fireairforce commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Fixed [#8354](https://github.com/biomejs/biome/issues/8354): Don't remove quotes when type memeber is new.
	Fixed [`#8354`](https://github.com/biomejs/biome/issues/8354): Don't remove quotes when type member is new.

Uh oh!

Conversation

fireairforce commented Feb 2, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

siketyan left a comment

Choose a reason for hiding this comment

Uh oh!

fireairforce commented Feb 2, 2026

Uh oh!

fireairforce commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ematipico commented Feb 2, 2026

Uh oh!

fireairforce commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot Bot commented Feb 2, 2026 •

edited

Loading

coderabbitai Bot commented Feb 2, 2026 •

edited

Loading

codspeed-hq Bot commented Feb 2, 2026 •

edited

Loading

fireairforce commented Feb 2, 2026 •

edited

Loading